Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EK-3 | EK-5 | EK-16: API for creating and manipulating drawings #1151

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mprins
Copy link
Contributor

@mprins mprins commented Feb 14, 2025

EK-3 Powered by Pull Request Badge

  • EK-3: initial API for creating and manipulating drawings
  • EK-5: Update CI compose stack to use a Postgis image so we can store drawing elements as proper geometry
  • EK-16: Flyway migration script to generate data schema and tables and cleanup unneeded extensions and schemas from base image
  • API implementation

@mprins mprins self-assigned this Feb 14, 2025
@mprins mprins added the enhancement New feature or request label Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #1151     +/-   ##
========================================
- Coverage      76%      4%    -71%     
  Complexity     87      87             
========================================
  Files         118     118             
  Lines        5657    5657             
  Branches      493     493             
========================================
- Hits         4250     222   -4028     
- Misses       1140    5417   +4277     
+ Partials      267      18    -249     

see 107 files with indirect coverage changes

Copy link

github-actions bot commented Feb 14, 2025

Test Results

0 tests   - 320   0 ✅  - 319   0s ⏱️ - 3m 46s
0 suites  -  33   0 💤  -   1 
0 files    -  33   0 ❌ ±  0 

Results for commit 4df3e59. ± Comparison against base commit 3734b59.

♻️ This comment has been updated with latest results.

@mprins mprins force-pushed the EK-3_store_drawing_api branch from 00044a0 to ea635e4 Compare February 14, 2025 13:21
@mprins mprins requested review from geertplaisier and Copilot and removed request for geertplaisier February 14, 2025 13:21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/main/resources/openapi/viewer-api.yaml: Language not supported
  • src/main/resources/openapi/viewer-schemas.yaml: Language not supported
@mprins mprins requested review from matthijsln and Copilot February 14, 2025 13:21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • src/main/resources/openapi/viewer-api.yaml: Language not supported
  • src/main/resources/openapi/viewer-schemas.yaml: Language not supported
@mprins mprins force-pushed the EK-3_store_drawing_api branch from ea635e4 to 8b4fabd Compare February 14, 2025 13:27
@mprins mprins changed the title EK-3: initial draft API for creating and manipulating drawings EK-3: initial API for creating and manipulating drawings Feb 17, 2025
@mprins mprins force-pushed the EK-3_store_drawing_api branch from a6ac32e to 15114fd Compare February 17, 2025 13:37
@mprins mprins force-pushed the EK-3_store_drawing_api branch from 15cfcef to 253c5a9 Compare February 17, 2025 16:01
… cleanup unneeded extensions and schemas from base image
@mprins mprins force-pushed the EK-3_store_drawing_api branch from 253c5a9 to 6675b67 Compare February 18, 2025 13:08
@mprins mprins changed the title EK-3: initial API for creating and manipulating drawings EK-3 | EK-5 | EK-16: API for creating and manipulating drawings Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant