Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛓️‍πŸ’₯ HTM-1091: Add feature geometry as a strong-type ⛓️‍πŸ’₯ #1025

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mprins
Copy link
Contributor

@mprins mprins commented Nov 8, 2024

HTM-1091 Powered by Pull Request Badge

⛓️‍πŸ’₯ Note: when upgrading you will need to fully redeploy the Solr service (including dropping any associated volumes) so full-text indexes can be recreated with the correct geometry type

Exposes extra search API parameters:d, pt and fq:

- description: '(Solr) distance search term (kilometers)'
in: query
name: d
required: true
schema:
type: number
format: double
- description: '(Solr) search point term'
in: query
name: pt
required: false
schema:
type: string
- description: '(Solr) filter query term'
in: query
name: fq
required: false
schema:
type: string

requires Tailormap/tailormap-data#13

@mprins mprins added enhancement New feature or request breaking possibly breaking changes that need extra attention during upgrade labels Nov 8, 2024
@mprins mprins self-assigned this Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

βœ… All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/main/java/org/tailormap/api/solr/SolrHelper.java 81% 1 Missing and 3 partials ⚠️

Impacted file tree graph

@@          Coverage Diff           @@
##             main   #1025   +/-   ##
======================================
+ Coverage      76%     76%   +1%     
  Complexity     86      86           
======================================
  Files         113     113           
  Lines        5205    5222   +17     
  Branches      457     460    +3     
======================================
+ Hits         3907    3920   +13     
- Misses       1056    1057    +1     
- Partials      242     245    +3     
Files with missing lines Coverage Ξ” Complexity Ξ”
...org/tailormap/api/controller/SearchController.java 76% <100%> (+1%) 0 <0> (ΓΈ)
...c/main/java/org/tailormap/api/solr/SolrHelper.java 82% <81%> (-<1%) 0 <0> (ΓΈ)

Copy link

github-actions bot commented Nov 8, 2024

Test Results

292 tests  +1   291 βœ… +1   3m 36s ⏱️ +11s
 31 suites Β±0     1 πŸ’€ Β±0 
 31 files   Β±0     0 ❌ Β±0 

Results for commit a360623. ± Comparison against base commit 06e8bd3.

♻️ This comment has been updated with latest results.

Also expose some extra parameters to enable search within distance and a testcase
@mprins mprins force-pushed the HTM-1091_strong-typed_solr_geometryfield branch from c4d61b1 to a360623 Compare November 11, 2024 15:36
@mprins mprins marked this pull request as ready for review November 11, 2024 15:40
@mprins mprins changed the title ⛓️‍πŸ’₯ [WIP] HTM-1091: Add feature geometry as a strong-type ⛓️‍πŸ’₯ ⛓️‍πŸ’₯ HTM-1091: Add feature geometry as a strong-type ⛓️‍πŸ’₯ Nov 11, 2024
@mprins mprins merged commit ad840f3 into main Nov 11, 2024
26 checks passed
@mprins mprins deleted the HTM-1091_strong-typed_solr_geometryfield branch November 11, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking possibly breaking changes that need extra attention during upgrade enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants