Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): Split prod and dev db, default to dev #1359

Merged
merged 3 commits into from
Feb 2, 2024
Merged

feat(db): Split prod and dev db, default to dev #1359

merged 3 commits into from
Feb 2, 2024

Conversation

boxbeam
Copy link
Contributor

@boxbeam boxbeam commented Feb 2, 2024

Closes #1272

NOTE: This will immediately present a breaking change for anyone who currently has a prod db and is expecting it to be used on startup. We might want to document this, but if so, which document(s)?

@boxbeam boxbeam requested a review from wsxiaoys February 2, 2024 18:43
@wsxiaoys
Copy link
Member

wsxiaoys commented Feb 2, 2024

Please also change:

  1. build_args: --features static-ssl
  2. cargo build --features cuda --release --package tabby && \

@wsxiaoys wsxiaoys marked this pull request as draft February 2, 2024 18:52
@wsxiaoys
Copy link
Member

wsxiaoys commented Feb 2, 2024

NOTE: This will immediately present a breaking change for anyone who currently has a prod db and is expecting it to be used on startup. We might want to document this, but if so, which document(s)?

It won't - since the only one we break are those running from our source code repository

@boxbeam boxbeam marked this pull request as ready for review February 2, 2024 19:00
@wsxiaoys wsxiaoys merged commit c151725 into main Feb 2, 2024
12 checks passed
@wsxiaoys wsxiaoys deleted the sqlx branch February 2, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TAB-461] Refactor database code to use sqlx instead of rusqlite
2 participants