Merge pull request #49 from TYPO3GmbH/undefined-array-key

Avoid possible undefined array key access
TYPO3GmbH · Mar 26, 2024 · 4d8aba4 · 4d8aba4
2 parents 5fab83a + a7b8399
commit 4d8aba4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Classes/Controller/FileVariantsController.php b/Classes/Controller/FileVariantsController.php
@@ -65,7 +65,7 @@ public function ajaxResetFileVariant(ServerRequestInterface $request): ResponseI
         $formData = $formDataCompiler->compile($formDataCompilerInput);
         $formData['renderType'] = 'fileInfo';
 
-        $fileUid = (int)$formData['databaseRow']['file'][0];
+        $fileUid = (int)($formData['databaseRow']['file'][0] ?? 0);
         $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)->getQueryBuilderForTable('sys_file');
         $fileRecord = $queryBuilder->select('l10n_parent')->from('sys_file')->where($queryBuilder->expr()->eq('uid', $queryBuilder->createNamedParameter($fileUid, Connection::PARAM_INT)))->executeQuery()->fetchAssociative();
 

diff --git a/Classes/FormEngine/FieldWizard/FileVariantsOverviewWizard.php b/Classes/FormEngine/FieldWizard/FileVariantsOverviewWizard.php
@@ -46,7 +46,7 @@ public function render(): array
         $result = $this->initializeResultArray();
 
         // no parent - we are in default language
-        $parentField = (int)$this->data['databaseRow']['l10n_parent'][0];
+        $parentField = (int)($this->data['databaseRow']['l10n_parent'][0] ?? 0);
         if ($parentField === 0) {
             $result['html'] .= '<div class="variants-preview">';
             $resourcesService = GeneralUtility::makeInstance(ResourcesService::class);

diff --git a/Classes/FormEngine/FileVariantInfoElement.php b/Classes/FormEngine/FileVariantInfoElement.php
@@ -49,7 +49,7 @@ public function render(): array
         $languageUid = $this->data['databaseRow']['sys_language_uid'];
 
         if ($languageUid > 0) {
-            $fileUid = (int)$this->data['databaseRow']['file'][0];
+            $fileUid = (int)($this->data['databaseRow']['file'][0] ?? 0);
             if ($fileUid < 1) {
                 $resultArray['html'] = 'something went wrong, no valid file uid received (' . $fileUid . ')';
             } else {
@@ -124,7 +124,7 @@ public function render(): array
      */
     protected function areRelatedFilesEqual(): bool
     {
-        $fileUid = (int)$this->data['databaseRow']['file'][0];
+        $fileUid = (int)($this->data['databaseRow']['file'][0] ?? 0);
         $defaultFileUid = $this->getDefaultFileUid();
 
         // this file has not been copied upon metadata translation. Probably we talk stale data.
@@ -147,7 +147,7 @@ protected function areRelatedFilesEqual(): bool
      */
     protected function getDefaultFileUid(): int
     {
-        $l10nParent = $this->data['databaseRow']['l10n_parent'][0]['uid'];
+        $l10nParent = $this->data['databaseRow']['l10n_parent'][0]['uid'] ?? 0;
 
         /** @var QueryBuilder $queryBuilder */
         $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)->getQueryBuilderForTable('sys_file_metadata');