-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove custom documentation of PhpStorm Gerrit plugin in appendix #357
Remove custom documentation of PhpStorm Gerrit plugin in appendix #357
Conversation
I agree. We should also remove the page itself, to prevent having an orphan entry (mobile atm, can't add that to the PR) |
IMO the existence of the plugin should still be mentioned. |
We could then only link to that plugin via marketplace URL https://plugins.jetbrains.com/plugin/7272-gerrit just like the TYPO3 plugin, and not give any special instructions which would make it our responsibility to describe it more properly? |
@garvinhicking added the link to the Marketplace now! |
@pixeldesu Thanks! Since I'm only on mobile, could you do me two more favors (or wait a bit until I can make it):
:-) |
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, thank you
Thanks! |
While the plugin can be set up, the setup is more convoluted and complex than the widely-used CLI setup that is documented pretty well in the contribution workflow anyway.So, in order for no one else stumbling upon this, it's best to just remove it.Not a lot of people in/around the Core circles use the PhpStorm Gerrit plugin. We noticed that there can be some issues with setting it up (depending on how deep you want the integration to go). As the plugin is still useful to some we're not fully removing any mention of it, but instead just link to the Marketplace without providing our own documentation around the plugin usage.