-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option for jExam like styling in Selma #149
base: main
Are you sure you want to change the base?
Conversation
This looks awesome, thanks a lot! A couple of questions on my side, as I am not at TUD anymore and out of the loop regarding Selma. I will have a closer look at the PR next week.
|
Grade distributionSelma provides a small button that opens a popup with a full table listing every grade with its count. The script extracts this link, downloads the html content and extracts the data from the table by querying the DOM. I'll leave comments to the relevant code sections below. The grade distributions seem to be grouped by birth year, though I am not 100% sure of this as I have very limited data, as of now I can say that two students who started the same degree in the same year and wrote the same exam at the same time seem to see the same grade distribution. But for example if student A writes an exam in his second semester together with student B who writes the exam in his 4th semester the grade distributions shown will be different. Even though they wrote the exact same exam on the same day. Enabling by defaultFor now I'd just enable the setting by default. Adding a button directly on the page is definitely a good idea so I'll try to implement this when I find the time for it :) Besides all this I have another question, right now this PR merges into |
promises.push( | ||
fetch(url).then(async (s) => { | ||
const parser = new DOMParser() | ||
const doc = parser.parseFromString(await s.text(), 'text/html') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracting the individual tries works pretty much the same, extracting the information is just a bit more complicated and unreliable. I am not 100% happy with how it is working right now as it still has trouble with some modules that format their information tables differently. For example language courses don't work as of now as shown in the picture below. Solving this issue definitely is not hard I just do not have the time right now :)
The individual tries also show the grade and date when hovering over them, the grade distribution charts also have tooltips showing what grade the bar represents. All graphics still act as clickable button that opens the original link just like before, though I am not sure if this immediately obvious and there might be a better solution to indicate to users that the charts are clickable
This is also a problem for me. We need new supporters but no one wants to do it and also develop the necessary updates :/ Sadly, I can't check this PR. |
Description
I propose the following changes in my PR:
The following before and after images visualize the change:
Type of change
Further info
Testing
We have 1500+ Users. Please test your changes thoroughly.
npm run test
locallyAdditional Information
The changes need to be turned on in the settings page, as of now the setting has the same Icon as the Opal settings. A different icon would probably be better but I am unfamiliar with the way the icons work so a bit of help would be appreciated :)
I also accidentally reformatted the
src/manifest.firefox.json
file, I hope this is not an issue