-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runner): implement runner registration with gocast #1490
Conversation
56cd658
to
244cc5e
Compare
a0e31ed
to
229dd3f
Compare
0e7d164
to
edd1a89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small nits, but everything else looks good to me 👍
Tested the Runner registration locally and it works as expected (the deregistration doesn't work yet, but that's intended, right?)
There is no deregistration, when we get to task scheduling on the runner, the last heartbeat should be considered to determine whether a runner is available. Heartbeat is not implemented yet though :D |
Ah ok; thanks for clarifying this 👍 |
Motivation and Context
As discussed, let's break down further development of the runner into smaller independent PRs.
Description
This PR implements the registration of the runner with gocast. This is achieved by:
FromRunner
is nowRunnerManagerService
)runner_manager
in gocast, which implementsRunnerManagerService
-> gocast is the runners managerSteps for Testing
Screenshots