Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed schedule for streams spanning multiple days #1485

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

karjo24
Copy link
Contributor

@karjo24 karjo24 commented Jan 28, 2025

Motivation and Context

See #1484.

Description

If a stream spans over multiple days, the corresponding calendar item between the start and end day will not have an inner element containing a start and end time. However, the function that injects the location into the calendar item will do so by appending the new location item to the time item. In the case of streams with duration >2d, the time item does not exist. This PR fixes this by manually injecting a custom time item when it doesn't exist yet.

Steps for Testing

Prerequisites:

  • 1 Admin
  1. Add a scheduled stream to the database. It must end at least 2 calendar days after the start time.
  2. Log in
  3. Navigate to a Admin Schedule
  4. See that no error is logged to the console, the left and right day/week navigation keys still work and the calendar item contains 12:00 - 12:00 as the time and a valid location.

@karjo24 karjo24 linked an issue Jan 28, 2025 that may be closed by this pull request
@karjo24 karjo24 self-assigned this Jan 28, 2025
@karjo24 karjo24 requested a review from a team January 28, 2025 14:28
@joschahenningsen joschahenningsen marked this pull request as draft February 4, 2025 16:11
@joschahenningsen joschahenningsen marked this pull request as ready for review February 4, 2025 16:11
web/ts/schedule.ts Outdated Show resolved Hide resolved
Co-authored-by: Joscha Henningsen <[email protected]>
@joschahenningsen joschahenningsen merged commit 0ebb418 into dev Feb 5, 2025
9 checks passed
@joschahenningsen joschahenningsen deleted the 1484-admin-schedule-week-view-broken branch February 5, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin Schedule Week View broken
2 participants