Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with long course titles #1304

Merged

Conversation

SebiWrn
Copy link
Collaborator

@SebiWrn SebiWrn commented Jan 10, 2024

Motivation and Context

Fixes UI bugs with long titles.

Description

Text will now be cut off if it's too long and only be shown on mouse hover.

Screenshots

image
image

@SebiWrn SebiWrn self-assigned this Jan 10, 2024
@SebiWrn SebiWrn linked an issue Jan 10, 2024 that may be closed by this pull request
Copy link

Your Testserver will be ready at https://1304.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@YiranDuan721
Copy link
Contributor

Looks good to me. Would it be a good idea to add "overflow-hidden" to all elements? Because this problem occurs anywhere...

@SebiWrn
Copy link
Collaborator Author

SebiWrn commented Jan 10, 2024

Maybe we can do this in an enh branch, but as a quick fix for this issue, this works for the lecture title. What do you think about this?

@SebiWrn SebiWrn enabled auto-merge (squash) January 10, 2024 14:42
@SebiWrn SebiWrn merged commit d6012c7 into dev Jan 10, 2024
9 checks passed
@SebiWrn SebiWrn deleted the 1301-long-words-in-lecture-titles-spoil-the-display-of-web-pages branch January 10, 2024 14:44
SebiWrn added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long words in lecture titles spoil the display of web pages
2 participants