-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPraktikum gocast API/v2 #1279
Draft
carlobortolan
wants to merge
51
commits into
dev
Choose a base branch
from
IPraktikum-dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
IPraktikum gocast API/v2 #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement fetching of current user from jwt token sent in request * Implement GET:/user/me endpoint * Update user message * Update * Clean up api_v2 file structure and implement , , , , * Add basic code-doc * Add `last_name` attribute to the user table * add bookmark, notification and alert endpoints * Update errors for bookmark-endpoints * Add course endpoints --------- Co-authored-by: Achraf Labidi <[email protected]> Co-authored-by: Moritz <[email protected]>
* Add postDeviceToken and notification_service.go * Implement basic push notifications using FCM * Implement basic push notifications using FCM * Add note * Add deleteDeviceToken endpoint * Add fcm push notification service to worker_grpc * Add serverKey to config.yaml and tools.config.go * Add &model.Device{} to tumlive.go automigration * Add FK to device_token model and update notification endpoints * Remove TODOs
* add user settings functionality to get and patch user settings * fix getting current user to change and get settings according to review
carlobortolan
added
documentation
Improvements or additions to documentation
go
Pull requests that update Go code
docker
Pull requests that update Docker code
feature ✨
labels
Dec 22, 2023
Your Testserver will be ready at https://1279.test.live.mm.rbg.tum.de in a few minutes. Logins
|
* Add basic tests for course gRPC endpoints * Add basic tests for gRPC notification endpoints * Fix testdb * Handle edge cases in stream and course endpoints * Implement basic tests for gRPC stream endpoints * Fix notification target bug * Fix public courses visibility bug * Run gofumpt -l -w ./api_v2 * Fix setup * fix settings enum indexing, 3 months name change cooldown and validation for empty names * add settings, bookmarks, pinned and user tests * Fix typo in user tests * Disable api_v2 tests --------- Co-authored-by: Moritz <[email protected]>
…t types to be consistent
Why was this closed? |
Looks like GitHub automatically closed the PR when I renamed the branch to enh/api_v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docker
Pull requests that update Docker code
documentation
Improvements or additions to documentation
go
Pull requests that update Go code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API/v2
Motivation and Context
This PR implements the current state of the new gocast gRPC API/v2 used by gocast mobile as part of the iPraktikum.
You can find a detailled documentation of all currently implemented gRPC methods in our Postman collection.
Description
Files changed outside the
api_v2
dir:Changes related to push notifications:
For the push notifications, we went with Firebase Cloud Messaging, as it is also used by the TUM Campus APP. If you want to enable push notifications, see this setup guide (TL;DR: Add the
fcmServerKey
entry to theconfig.yaml
and you're good to go).tools/config.go
model/user.go
dao/courses.go
config.yaml
api/worker_grpc.go
cmd/tumlive/tumlive.go
go.mod
Expose port 12544 for gRPC API/v2:
Steps for Testing
See Postman collection for different test cases for each gRPC method.