Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popupContext ws subscription is added. #1253

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

barisgul15
Copy link
Contributor

Motivation and Context

Fixes the issue Popup chat does not update #1199

Description

When pop-up chat is opened, a new web socket(ws) is created so that the new chat can work properly. When examined, the only difference between normal-chat(chat near video) and popup chat is that, normal chat subscribes a void handler when created, but popup chat does not do that. As a solution, a void handler is created on popup.ts and the web socket subscribed via this handler and popup chat started working.

Steps for Testing

Prerequisites:

  • 1 Lecturer
  1. Log in
  2. Create a course and enable chat
  3. Create a lecture and open the chats lecture
  4. Open the popup chat and test sendin messages in both chats and check whether both checks are updated accordingly.

Screenshots

@barisgul15 barisgul15 linked an issue Dec 6, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Dec 6, 2023

Your Testserver will be ready at https://1253.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Contributor

@YiranDuan721 YiranDuan721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested locally and see the popup chat works correctly with the change. New posts and reactions from the sidebar chat and from another user in another browser are immediately updated in the popup chat; messages and reactions sent in the popup-chat are also updated in other windows.
However I think the comments are redundant and can be removed.

Copy link
Collaborator

@alexanderstephan alexanderstephan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎉 A surprisingly simple fix. I would like to merge and deploy this as soon as possible, so we can use it in the lecture on Wednesday.

I don't really mind the comments.

@alexanderstephan
Copy link
Collaborator

@meandaD If it is okay for you, I would merge it as it is to avoid further delays. Feel free to press merge yourself.

@YiranDuan721
Copy link
Contributor

Awesome! 🎉 A surprisingly simple fix. I would like to merge and deploy this as soon as possible, so we can use it in the lecture on Wednesday.

I don't really mind the comments.

I gree with this

@YiranDuan721 YiranDuan721 merged commit b34e286 into dev Dec 12, 2023
9 checks passed
@YiranDuan721 YiranDuan721 deleted the 1199-popup-chat-does-not-update branch December 12, 2023 09:18
SebiWrn pushed a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Popup chat does not update
3 participants