Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add lecture time change #1168

Open
wants to merge 85 commits into
base: dev
Choose a base branch
from
Open

Conversation

mono424
Copy link
Collaborator

@mono424 mono424 commented Sep 21, 2023

Motivation and Context

No possibility to change date and time of a lecture.

Description

  • Added Timing Fields to Lectures
  • Added Logs to changeSet
  • Added Computed Properties

Steps for Testing

Prerequisites:

  • 1 Lecturer
  1. Log in
  2. Navigate to a Course Management Page
  3. Change Date Time of a Lecture
  4. Reload Page
  5. Check if Time Date is still changed
  6. Check if other settings can be changed too.

Screenshots

Bildschirmaufnahme.2023-09-28.um.00.20.11.mov

Bildschirmfoto 2023-09-27 um 22 03 55

@github-actions
Copy link

Your Testserver will be ready at https://1168.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@mono424 mono424 marked this pull request as ready for review September 27, 2023 22:23
@joschahenningsen
Copy link
Member

@mono424 thanks! Do you have time to resolve the conflicts?

@mono424
Copy link
Collaborator Author

mono424 commented Sep 30, 2023

@mono424 thanks! Do you have time to resolve the conflicts?

Sure currently not at a computer but will do today!

@mono424
Copy link
Collaborator Author

mono424 commented Sep 30, 2023

@mono424 thanks! Do you have time to resolve the conflicts?

Merged and also fixed an issue: On metadata chagnes I have sent the different requests in parallel resulting in the backend overwriting the changes other changes because it loads the model first and writes then the updated model for some reason. Now making it in one after another :)

1 similar comment
@mono424
Copy link
Collaborator Author

mono424 commented Sep 30, 2023

@mono424 thanks! Do you have time to resolve the conflicts?

Merged and also fixed an issue: On metadata chagnes I have sent the different requests in parallel resulting in the backend overwriting the changes other changes because it loads the model first and writes then the updated model for some reason. Now making it in one after another :)

@mono424
Copy link
Collaborator Author

mono424 commented Oct 18, 2023

@joschahenningsen Any update on this ? :)

@SebiWrn SebiWrn mentioned this pull request Oct 21, 2024
@SebiWrn SebiWrn enabled auto-merge (squash) October 21, 2024 13:12
@SebiWrn SebiWrn disabled auto-merge October 21, 2024 13:13
@alexanderstephan alexanderstephan self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants