Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vtl tract sequence to ema and mesh #53

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

derNarr
Copy link
Contributor

@derNarr derNarr commented Mar 31, 2023

adds frameSamplingRate argument to vtlTractSequenceToEmaAndMesh in order to get the correct time stamps in the exported ema file for non 200Hz frame frequencies

@derNarr
Copy link
Contributor Author

derNarr commented Mar 31, 2023

We should bump the version number. This change, changes the API by adding a parameter to a function that was never advertised. Still people who rely on the function now need to define the extra parameter with frameSamplingRate=200.0 to get the old behavior. On the other hand, one source of error is removed as it was never documented that the frame rate of the tract and glottis tract sequence frames have to be at 200Hz. Therefore this could be considered as a bug as well and therefore it might be treated as a bug fix.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant