Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to VS2022 #1

Merged
merged 0 commits into from
Nov 26, 2021
Merged

Upgraded to VS2022 #1

merged 0 commits into from
Nov 26, 2021

Conversation

TTimo
Copy link
Owner

@TTimo TTimo commented Nov 17, 2021

No description provided.

@TTimo
Copy link
Owner Author

TTimo commented Nov 17, 2021

@justcla would you consider merging 62ef612 in your release? (see zbrad#16)

Only reason I maintain this fork myself..

@justcla
Copy link

justcla commented Nov 17, 2021

My concern is that it will enable Delete Selection Mode without any way to turn it off.
This might be unexpected behaviour for many users.
Is there a way to toggle the setting on and off. If so, the merged changed should default the setting to be the same as it is now. Then it becomes opt-in instead of "what the hell just happened to my code?!"

@justcla
Copy link

justcla commented Nov 18, 2021

Looking further into it, I notice that M-x (Alt-X) is the standard shortcut to toggle Delete-Selection-Mode on and off.
Would you consider adding a new command that toggles delete-selection-mode?

Ideally, the setting should persist through VS restarts. For that, I would save the setting in the UserSettingStore and read it back in when the extension initializes. (Examples of that exist in the KeyboardShortcutsManager - if you want to try implementing that.)

@justcla
Copy link

justcla commented Nov 18, 2021

I note this feature has been previously requested from other users. If you were able to bring this into this extension (with a toggle switch, and off by default), it will be most welcome!

@TTimo TTimo merged commit 4f67274 into TTimo:master Nov 26, 2021
@TTimo
Copy link
Owner Author

TTimo commented Nov 26, 2021

@justcla I hardly know anything about C# or Visual Studio extensions, adding some configurable setting for this won't be trivial for me. Are you suggesting this should be done via some silent M-x shortcut (that doesn't sound right), or maybe with some option page? (I found this: https://docs.microsoft.com/en-us/visualstudio/extensibility/creating-an-options-page?view=vs-2022 - might be helpful?)

@justcla
Copy link

justcla commented Nov 27, 2021

Well, yes. I notice that normal Emacs behaviour uses M-x to toggle in and out of delete selection mode.
But, creating a new command is not always that easy. Worse still, the VSK with all the key bindings was built many years ago and there is no vssettings file from which to recreate it. (However, one could be generated and grabbed fun the folder in AppData.)

Otherwise, the Options Page might be an easier thing to implement. But the user will need to go into the settings to turn it off and on.

@justcla
Copy link

justcla commented Nov 27, 2021

I don't love this extension enough to struggle with it. Maybe you could publish your version on the Marketplace for people who prefer delete selection mode anyways on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants