Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor modules to make them more consistent and split out CLI #31

Merged
merged 8 commits into from
Dec 8, 2024

Conversation

QMalcolm
Copy link
Collaborator

@QMalcolm QMalcolm commented Dec 8, 2024

Is there an associated github issue?

No

What is this PR changing?

This is an organizational refactor. No inputs/outputs were changed. I found that the boundaries of some modules were blurring, like characters and rule_systems which deserved to be disentangled. Additionally the cli.ex file was becoming unwieldy. Splitting it into multiple sub modules will make it easier to continue developing on.

Copy link
Collaborator Author

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self approval ✔️

@QMalcolm QMalcolm merged commit 267b236 into main Dec 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant