Ensure CLI results for rolling dice are printed as integers #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IO.inspect` by default treats lists of integers as `charlists`. This means certain integer combinations result in the list being printed as `charlist`. This was rather confusing, as getting `~c"\a\n"` when rolling `2d10` doesn't make much sense (`~c"\a\n"` == `[7, 10]`). To force `IO.inspect` to read the list as a list of integers, we had to pass `charlists: :as_lists` in the opts of the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there an associated github issue?
resolves #26
What is this PR changing?
IO.inspectby default treats lists of integers ascharlists. This means certain integer combinations result in the list being printed ascharlist. This was rather confusing, as getting~c"\a\n"when rolling2d10doesn't make much sense (~c"\a\n"==[7, 10]). To forceIO.inspectto read the list as a list of integers, we had to passcharlists: :as_listsin the opts of the function.