Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes None
Additional comments
This check become useless. We are currently creating the list of operations from the dag and eventually assign them a playbook if define. Dag operations with no associated playbook are then treated as "noop". Hence, we are not using the
noop
property anymore.Furthermore, this check doesn't cover the case where a noop is defined in
collection1
and then is completed with a playbook defined incollection2
.I suggest to also remove entirely the
noop
property from the dag files (in the collections) are it is not used anymore.Agreements