Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noop playbook check #629

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove noop playbook check #629

wants to merge 1 commit into from

Conversation

PaulFarault
Copy link
Contributor

Which issue(s) this PR fixes

Fixes None

Additional comments

This check become useless. We are currently creating the list of operations from the dag and eventually assign them a playbook if define. Dag operations with no associated playbook are then treated as "noop". Hence, we are not using the noop property anymore.

Furthermore, this check doesn't cover the case where a noop is defined in collection1 and then is completed with a playbook defined in collection2.

I suggest to also remove entirely the noop property from the dag files (in the collections) are it is not used anymore.

Agreements

@PaulFarault PaulFarault self-assigned this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant