Prepare ground for Operation refactor #583
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noop flag is not used anymore by tdp-lib from a previous commit
Collection is not specified for each operation so this partial does not make sense anymore.
…rations instead of start
…restart operations
SteBaum
reviewed
Apr 17, 2024
| f"Operation '{operation.name}' is an install action, depends on '{dependency}' which is " | ||
| f"not an install action and should only depends on other install action" | ||
| f"Operation '{operation.name}' depends on '{dependency}' which is " | ||
| f"not an install action. Install operations should only depends on " |
There was a problem hiding this comment.
typo: "Install operations should only depend on" instead of "depends on"
|
When I modify the variables and do a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes None
Additional comments
Preparation work to handle the move from
LegacyOperationto the newOperationclass in another PR.Agreements