Permissions attribute for targets, filtering logic and migrations #1175
+434
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a permissions field on the Target that allows for filtering prior to doing row-level permissions for open/public targets. This significantly improves performance for TOMs with large datasets that are mostly open or public. Included migrations should handle the transition transparently. Todo: [] Extend filtering logic beyond the TargetList view. [] Update target creation logic away from the Public group. [] Apply logic to non-target models? [] Tests. [] Clean up any remaining 'Public' group logic. [] Update documentation.
It doesn't make a lot of sense to display the group form on the target create/update forms if the target is not private. This commit introduces a UI using a small amount of javascript that will hide the group form unless the user sets the target to private. Because this wasn't possible to implement with the generic form rendering in use, this commit also updates the target update and create forms to use a more compact layout instead of placing every field on a single row, increasing usability. The fields will still collapse to single rows on narrow viewports. Custom target types will default to the generic form rendering as before.
Fingel
commented
Feb 13, 2025
| @@ -306,6 +311,10 @@ class BaseTarget(models.Model): | |||
| auto_now=True, verbose_name='Last Modified', | |||
| help_text='The time which this target was changed in the TOM database.' | |||
| ) | |||
| permissions = models.CharField( | |||
| max_length=100, default=Permissions.PUBLIC, choices=Permissions.choices, | |||
There was a problem hiding this comment.
Should we set the default to private? It's possible people have built pipelines already with the assumption that newly created targets will have row-level permissions enforced.
Fingel
commented
Feb 13, 2025
| @@ -35,3 +34,6 @@ <h3>Tags</h3> | |||
| {% endbuttons %} | |||
| </form> | |||
| {% endblock %} | |||
| {% block extra_javascript %} | |||
| <script defer src="https://cdn.jsdelivr.net/npm/[email protected]/dist/cdn.min.js"></script> | |||
There was a problem hiding this comment.
Alpine.js is going to be useful for some of the other stories relating to making the UI more responsive. I'm not up to date on how we are handling static assets, but at the least this can be moved to base.html.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a permissions field on the Target that allows for filtering prior to doing row-level permissions for open/public targets. This significantly improves performance for TOMs with large datasets that are mostly open or public.
Included migrations should handle the transition transparently.
Todo: