Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junit4-support for @ArchTest instance fields or non-static methods in abstract base classes #105

Merged
merged 4 commits into from
Aug 30, 2018
Merged

Junit4-support for @ArchTest instance fields or non-static methods in abstract base classes #105

merged 4 commits into from
Aug 30, 2018

Conversation

hankem
Copy link
Member

@hankem hankem commented Aug 28, 2018

Resolves #104

@hankem hankem changed the title Junit4-support for @ArchTest instance fields or static methods in abstract base classes – Resolves #123 Junit4-support for @ArchTest instance fields or static methods in abstract base classes – Resolves #104 Aug 28, 2018
@hankem hankem changed the title Junit4-support for @ArchTest instance fields or static methods in abstract base classes – Resolves #104 Junit4-support for @ArchTest instance fields or static methods in abstract base classes Aug 28, 2018
…sses, we should separate the tests accordingly

Issue: #104
Signed-off-by: Peter Gafert <[email protected]>
@codecholeric
Copy link
Collaborator

I split the tests a little, since there are three different test classes that deal with the runner running fields, methods and rule sets respectively. Can argue if that split is so great, but as long as it's there, I think each aspect should be sorted in the respective test class (e.g. no test in ArchUnitRunnerRunsFieldsTest dealt with ArchRules.in(..) so far)
Besides that, thanks a lot!! 😄 Gonna merge it, as soon as Travis is through.

@codecholeric codecholeric merged commit b886d09 into TNG:master Aug 30, 2018
@hankem hankem deleted the Junit4-support_for_abstract_base_classes branch October 17, 2018 05:46
codecholeric added a commit that referenced this pull request Feb 21, 2021
…classes

Junit4-support for @archtest instance fields or static methods in abstract base classes
@hankem hankem changed the title Junit4-support for @ArchTest instance fields or static methods in abstract base classes Junit4-support for @ArchTest instance fields or non-static methods in abstract base classes May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants