Instead of sync on PersistentMemberManager using CopyOnWrite structure #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a deadlock with revoke and unblock where revoke was taking lock on PersistentMemberManager and then requires lock on PersistenceAdvisorImpl. The intialization thread takes lock PersistenceAdvisorImpl and then to check whether the diskid is unblocked and requires lock on PersistentmemberManager
ashetkar
force-pushed
the
revoke-deadlock
branch
from
a1b55cc
to
5f48e23
Compare
sumwale
force-pushed
the
snappy/master
branch
2 times, most recently
from
337768c
to
ec453a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a deadlock with revoke and unblock where revoke was taking
lock on PersistentMemberManager and then requires lock on PersistenceAdvisorImpl.
The intialization thread takes lock PersistenceAdvisorImpl and then to check
whether the diskid is unblocked and requires lock on PersistentmemberManager
Changes proposed in this pull request
(Fill in the changes here)
Patch testing
(Fill in the details about how this patch was tested)
Is precheckin with -Pstore clean?
ReleaseNotes changes
(Does this change require an entry in ReleaseNotes? If yes, has it been added to it?)
Other PRs
(Does this change require changes in other projects- snappydata, spark, spark-jobserver, aqp? Add the links of PR of the other subprojects that are related to this change)