Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'repeat-delete' #20

Closed
wants to merge 1 commit into from
Closed

'repeat-delete' #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/server/include/query_engine/analyzer/statement/filter_stmt.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,7 @@ class FilterUnit
public:
FilterUnit() = default;
~FilterUnit()
{
// FilterUnit 只会在 create_filter_unit 中创建，这里的左右表达式都是独占所有权，需要释放
delete left_expr_;
delete right_expr_;
}
{}

void set_comp(CompOp comp)
{
Expand Down
6 changes: 3 additions & 3 deletions src/server/query_engine/analyzer/statement/select_stmt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ SelectStmt::~SelectStmt()
delete group_by_stmt_;
delete having_stmt_;
delete order_stmt_;
for (auto *join_filter_stmt : join_filter_stmts_) {
delete join_filter_stmt;
}
// for (auto *join_filter_stmt : join_filter_stmts_) {
// delete join_filter_stmt;
// }
}

static void wildcard_fields_without_table_name(Table *table, std::vector<Expression*> &projects, const std::string &table_name) {
Expand Down