fix: fix issues detected by address sanitizer

src/server/include/query_engine/analyzer/statement/filter_stmt.h

@@ -35,7 +35,11 @@ class FilterUnit
 public:
   FilterUnit() = default;
   ~FilterUnit()
-  {}
+  {
+    // FilterUnit 只会在 create_filter_unit 中创建，这里的左右表达式都是独占所有权，需要释放
+    delete left_expr_;
+    delete right_expr_;
+  }
 
   void set_comp(CompOp comp)
   {

src/server/include/query_engine/analyzer/statement/update_stmt.h

@@ -15,6 +15,7 @@ class UpdateStmt : public Stmt
 {
 public:
   UpdateStmt(Table *table, std::vector<UpdateUnit> update_units, FilterStmt *filter_stmt);
+  ~UpdateStmt();
 
 public:
   static RC create(Db *db, const UpdateSqlNode &update_sql, Stmt *&stmt);

src/server/include/query_engine/planner/node/update_logical_node.h

@@ -10,7 +10,7 @@ class UpdateLogicalNode : public LogicalNode
 {
 public:
   UpdateLogicalNode(Table *table, std::vector<UpdateUnit> update_units);
-  ~UpdateLogicalNode() override = default;
+  ~UpdateLogicalNode() override;
 
   LogicalNodeType type() const override
   {
@@ -19,7 +19,7 @@ class UpdateLogicalNode : public LogicalNode
   Table *table() const {
     return table_;
   }
-  std::vector<UpdateUnit> update_units() {
+  std::vector<UpdateUnit> &update_units() {
     return update_units_;
   }
 private:

src/server/include/query_engine/planner/operator/update_physical_operator.h

@@ -15,7 +15,7 @@ class UpdatePhysicalOperator : public PhysicalOperator
   UpdatePhysicalOperator(Table *table, std::vector<UpdateUnit> update_units) : table_(table), update_units_(std::move(update_units))
   {}
 
-  virtual ~UpdatePhysicalOperator() = default;
+  virtual ~UpdatePhysicalOperator();
 
   PhysicalOperatorType type() const override
   {

src/server/include/query_engine/structor/tuple/tuple_cell.h

@@ -16,6 +16,8 @@ class TupleCellSpec
   TupleCellSpec(const char *table_name, const char *field_name, const char *alias = nullptr);
   explicit TupleCellSpec(const char *alias);
 
+  ~TupleCellSpec();
+
   const char *table_name() const {
     return table_name_.c_str();
   }

src/server/include/storage_engine/buffer/buffer_pool.h

@@ -49,6 +49,7 @@ class FileBufferPool
    * 将dirty frame中的数据刷新到磁盘上
    */
   RC flush_page(Frame &frame);
+  RC flush_all_pages();
 
   /**
    * 驱逐frame

src/server/query_engine/analyzer/statement/select_stmt.cpp

@@ -12,10 +12,25 @@
 
 SelectStmt::~SelectStmt()
 {
+  // 这些都是 create 中创建的对象，独占所有权，需要释放
+  for (auto *field : query_fields_) {
+    delete field;
+  }
+  for (auto *project : projects_) {
+    delete project;
+  }
+
   if (nullptr != filter_stmt_) {
     delete filter_stmt_;
     filter_stmt_ = nullptr;
   }
+
+  delete group_by_stmt_;
+  delete having_stmt_;
+  delete order_stmt_;
+  for (auto *join_filter_stmt : join_filter_stmts_) {
+    delete join_filter_stmt;
+  }
 }
 
 static void wildcard_fields_without_table_name(Table *table, std::vector<Expression*> &projects, const std::string &table_name) {
@@ -345,7 +360,7 @@ RC SelectStmt::create(Db *db, const SelectSqlNode &select_sql, Stmt *&stmt)
   select_stmt->group_by_stmt_ = group_by_stmt;
   select_stmt->having_stmt_ = having_stmt;
   select_stmt->order_stmt_ = order_stmt;
-  select_stmt->join_filter_stmts_ = join_filter_stmts;
+  select_stmt->join_filter_stmts_.swap(join_filter_stmts);
   stmt = select_stmt;
   return RC::SUCCESS;
 }

src/server/query_engine/analyzer/statement/update_stmt.cpp

@@ -9,6 +9,15 @@
 UpdateStmt::UpdateStmt(Table *table, std::vector<UpdateUnit> update_units, FilterStmt *filter_stmt) : table_(table), update_units_(std::move(update_units)), filter_stmt_(filter_stmt)
 {}
 
+UpdateStmt::~UpdateStmt()
+{
+  // 这些都是 create 中创建的对象，独占所有权，需要释放
+  delete filter_stmt_;
+  for (auto &unit : update_units_) {
+    delete unit.value;
+  }
+}
+
 RC UpdateStmt::create(Db *db, const UpdateSqlNode &update, Stmt *&stmt)
 {
   const char *table_name = update.relation_name.c_str();

src/server/query_engine/executor/execution_engine.cpp

@@ -25,6 +25,7 @@ RC write_to_communicator(const char* data, int32_t size, Communicator* communica
       LOG_WARN("failed to send data to client. err=%s", strerror(errno));
       return rc;
     }
+    delete[] padding;
   }
   RC rc = communicator->write_result(data, size);
   if(RC_FAIL(rc)){

src/server/query_engine/parser/yacc_sql.cpp

@@ -2003,7 +2003,7 @@ YYLTYPE yylloc = yyloc_default;
 		(yyval.multi_attribute_names) = new std::vector<std::string>;
 	}
 	(yyval.multi_attribute_names)->emplace_back((yyvsp[-1].string));
-	delete (yyvsp[-1].string);
+	free((yyvsp[-1].string));
   }
 #line 2009 "yacc_sql.cpp"
     break;
@@ -2768,7 +2768,7 @@ YYLTYPE yylloc = yyloc_default;
       relAttrSqlNode->relation_name  = (yyvsp[-3].string);
       relAttrSqlNode->attribute_name = "*";
       (yyval.expression_list)->emplace_back(new RelAttrExpr(*relAttrSqlNode));
-      delete (yyvsp[-3].string);
+      free((yyvsp[-3].string));
     }
 #line 2774 "yacc_sql.cpp"
     break;
@@ -2837,7 +2837,7 @@ YYLTYPE yylloc = yyloc_default;
       relAttrSqlNode->relation_name  = (yyvsp[-3].string);
       relAttrSqlNode->attribute_name = "*";
       (yyval.expression_list)->emplace_back(new RelAttrExpr(*relAttrSqlNode));
-      delete (yyvsp[-3].string);
+      free((yyvsp[-3].string));
     }
 #line 2843 "yacc_sql.cpp"
     break;
@@ -2907,7 +2907,7 @@ YYLTYPE yylloc = yyloc_default;
       (yyval.rel_attr) = new RelAttrSqlNode;
       (yyval.rel_attr)->relation_name = "";
       (yyval.rel_attr)->attribute_name = (yyvsp[0].string);
-      delete (yyvsp[0].string);
+      free((yyvsp[0].string));
     }
 #line 2913 "yacc_sql.cpp"
     break;
@@ -2918,8 +2918,8 @@ YYLTYPE yylloc = yyloc_default;
       (yyval.rel_attr) = new RelAttrSqlNode;
       (yyval.rel_attr)->relation_name  = (yyvsp[-2].string);
       (yyval.rel_attr)->attribute_name = (yyvsp[0].string);
-      delete (yyvsp[-2].string);
-      delete (yyvsp[0].string);
+      free((yyvsp[-2].string));
+      free((yyvsp[0].string));
     }
 #line 2925 "yacc_sql.cpp"
     break;
@@ -2957,7 +2957,7 @@ YYLTYPE yylloc = yyloc_default;
         (yyval.relation_list) = new std::vector<RelationSqlNode>;
       }
       (yyval.relation_list)->push_back(*(yyvsp[-1].relation));
-      free((yyvsp[-1].relation));
+      delete (yyvsp[-1].relation);
     }
 #line 2963 "yacc_sql.cpp"
     break;
@@ -3044,7 +3044,7 @@ YYLTYPE yylloc = yyloc_default;
       delete (yyvsp[-1].condition_list);
       (yyval.join_list)->emplace_back(*joinSqlNode);
       delete joinSqlNode;
-      free((yyvsp[-2].relation));
+      delete (yyvsp[-2].relation);
     }
 #line 3050 "yacc_sql.cpp"
     break;

src/server/query_engine/parser/yacc_sql.y

@@ -363,7 +363,7 @@ multi_attribute_names:
 		$$ = new std::vector<std::string>;
 	}
 	$$->emplace_back($2);
-	delete $2;
+	free($2);
   }
   ;
 
@@ -869,7 +869,7 @@ select_attr:
       relAttrSqlNode->relation_name  = $1;
       relAttrSqlNode->attribute_name = "*";
       $$->emplace_back(new RelAttrExpr(*relAttrSqlNode));
-      delete $1;
+      free($1);
     } | add_expr expression_list {
       if ($2 != nullptr) {
         $$ = $2;
@@ -912,7 +912,7 @@ expression_list:
       relAttrSqlNode->relation_name  = $2;
       relAttrSqlNode->attribute_name = "*";
       $$->emplace_back(new RelAttrExpr(*relAttrSqlNode));
-      delete $2;
+      free($2);
     } | COMMA add_expr expression_list {
       if ($3 != nullptr) {
         $$ = $3;
@@ -956,13 +956,13 @@ rel_attr:
       $$ = new RelAttrSqlNode;
       $$->relation_name = "";
       $$->attribute_name = $1;
-      delete $1;
+      free($1);
     } | ID DOT ID {
       $$ = new RelAttrSqlNode;
       $$->relation_name  = $1;
       $$->attribute_name = $3;
-      delete $1;
-      delete $3;
+      free($1);
+      free($3);
     }
     ;
 
@@ -989,7 +989,7 @@ relation_list:
         $$ = new std::vector<RelationSqlNode>;
       }
       $$->push_back(*$1);
-      free($1);
+      delete $1;
     }
     ;
 
@@ -1048,7 +1048,7 @@ join_list:
       delete $4;
       $$->emplace_back(*joinSqlNode);
       delete joinSqlNode;
-      free($3);
+      delete $3;
     }
     ;
 

src/server/query_engine/planner/node/update_logical_node.cpp

@@ -1,4 +1,12 @@
 #include "include/query_engine/planner/node/update_logical_node.h"
 
 UpdateLogicalNode::UpdateLogicalNode(Table *table, std::vector<UpdateUnit> update_units) : table_(table), update_units_(std::move(update_units))
-{}
+{}
+
+UpdateLogicalNode::~UpdateLogicalNode()
+{
+  // update_units_ 在 plan_node 中 copy 了一份，这里需要释放
+  for (auto &unit : update_units_) {
+    delete unit.value;
+  }
+}

src/server/query_engine/planner/operator/physical_operator_generator.cpp

@@ -218,7 +218,8 @@ RC PhysicalOperatorGenerator::create_plan(
 
   auto *project_operator = new ProjectPhysicalOperator(&project_oper);
   for (const auto &i : project_oper.expressions()) {
-    project_operator->add_projector(i->copy());
+    // TupleCellSpec 的构造函数中已经 copy 了 Expression，这里无需 copy
+    project_operator->add_projector(i.get());
   }
 
   if (child_phy_oper) {
@@ -285,7 +286,8 @@ RC PhysicalOperatorGenerator::create_plan(UpdateLogicalNode &update_oper, unique
     }
   }
 
-  oper = unique_ptr<PhysicalOperator>(new UpdatePhysicalOperator(update_oper.table(), update_oper.update_units()));
+  // 将 update_units 从逻辑算子转移给物理算子，避免重复释放
+  oper = unique_ptr<PhysicalOperator>(new UpdatePhysicalOperator(update_oper.table(), std::move(update_oper.update_units())));
 
   if (child_physical_oper) {
     oper->add_child(std::move(child_physical_oper));

src/server/query_engine/planner/operator/update_physical_operator.cpp

@@ -9,6 +9,14 @@
 #include "include/query_engine/structor/expression/value_expression.h"
 #include "include/query_engine/structor/tuple/row_tuple.h"
 
+UpdatePhysicalOperator::~UpdatePhysicalOperator()
+{
+  // 这些 update_units 从逻辑算子中转移过来，独占所有权，需要释放
+  for (auto &unit : update_units_) {
+    delete unit.value;
+  }
+}
+
 RC UpdatePhysicalOperator::open(Trx *trx)
 {
   if (children_.empty()) {
@@ -84,6 +92,9 @@ RC UpdatePhysicalOperator::open(Trx *trx)
     unit.value = new ValueExpr(value);
     processed_update_units.emplace_back(unit);
   }
+  for (auto &unit : update_units_) {
+    delete unit.value;
+  }
   update_units_.clear();
   update_units_ = std::move(processed_update_units);
   return RC::SUCCESS;

src/server/query_engine/structor/tuple/tuple_cell.cpp

@@ -26,3 +26,9 @@ TupleCellSpec::TupleCellSpec(const char *alias)
     alias_ = alias;
   }
 }
+
+TupleCellSpec::~TupleCellSpec()
+{
+  // 构造时 copy 了一份 expression，这里需要释放
+  delete expression_;
+}

src/server/session/server.cpp

@@ -301,6 +301,8 @@ int Server::start_stdin_server()
 
     /// 在当前线程立即处理对应的事件
     bool need_disconnect = query_engine_.process_session_request(event);
+    // event 对象在 read_event 中创建，需要在这里释放
+    delete event;
     if(need_disconnect){
       // 函数最后已经做了清理工作，且 stdin server 不需要创建 read_event
       // 所以此处无需调用 close_connection，直接退出循环即可

src/server/storage_engine/buffer/buffer_pool.cpp

@@ -221,6 +221,26 @@ RC FileBufferPool::flush_page_internal(Frame &frame)
   return RC::SUCCESS;
 }
 
+/**
+ * 将所有的脏页刷盘
+ */
+RC FileBufferPool::flush_all_pages()
+{
+  std::scoped_lock lock_guard(lock_);
+  RC rc = RC::SUCCESS;
+  for (Frame *frame : frame_manager_.find_list(file_desc_)) {
+    if (frame->dirty()) {
+      RC _rc = flush_page_internal(*frame);
+      if (_rc != RC::SUCCESS) {
+        LOG_ERROR("Failed to flush page %s:%d, rc=%s", file_name_.c_str(), frame->page_num(), strrc(_rc));
+        rc = _rc;
+      }
+    }
+    frame->unpin();
+  }
+  return rc;
+}
+
 /**
  * TODO [Lab1] 需要同学们实现某个指定页面的驱逐
  */