fix: wrong index in cell_at() of JoinTuple and redundant species when calling open() repeatedly #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycycse
reviewed
May 7, 2024
| @@ -40,6 +40,7 @@ class RowTuple : public Tuple | |||
| { | |||
| table_ = table; | |||
| table_alias_ = table_alias; | |||
| species_.clear(); | |||
ycycse
approved these changes
May 7, 2024
hotwords123
reviewed
May 7, 2024
| @@ -40,6 +40,7 @@ class RowTuple : public Tuple | |||
| { | |||
| table_ = table; | |||
| table_alias_ = table_alias; | |||
| species_.clear(); | |||
There was a problem hiding this comment.
这里直接 clear 是不是会造成内存泄漏，其实可以考虑把 species_ 换成 vector<unique_ptr<FieldExpr>>，用 RAII 管理内存？
There was a problem hiding this comment.
这里直接
clear是不是会造成内存泄漏，其实可以考虑把species_换成vector<unique_ptr<FieldExpr>>，用 RAII 管理内存？
确实会，但你这个是小众场景，引入一个智能指针是不是没必要？
你可以手动维护一下指针的释放，然后判断一下如果species_不为空，再做对应的操作
ycycse
changed the title
ycycse
reviewed
May 7, 2024
| for(auto& field_expr : species_){ | ||
| delete field_expr; //clear()前先释放目前的fields | ||
| } | ||
| species_.clear();/// 在TableScanPhysicalOperator::open()会调用set_schema。 |
There was a problem hiding this comment.
不光是table_scan_operator，index_scan_operator也会调用这个方法，只是当open()被调用多次调用set_schema时，需要做对应的清理
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug 1: join tuple cannot be visited by cell_at() at position 0
bug 2: row tuple's schema will be double or triple initialized when trying to reopen table scanner