fix: add force copy ability of class Value; unmatch between IndexScanPhysicalOperator and index_->create_scanner #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
问题背景:
select * from index_lab where id > 99997;
问题在于源码中没有能够将nullptr传递下去而是默认传递其内部的right_value_.data()(在上述例子的情况下),导致BplusTreeScanner::open失败
修改思路:
添加
left_null_
和right_null_
的标识量,修改index_->create_scanner的传参逻辑即可,不影响原来的逻辑。Background:
select * from index_lab where id > 99997;
The problem is that the source code does not allow nullptr to be passed down but instead defaults to passing its internal right_value_.data() (in the aforementioned example), which causes BplusTreeScanner::open to fail.
Proposed Modification:
Add flags for
left_null_
andright_null_
, and modify the parameter logic in index_->create_scanner accordingly. This should not affect the original logic.