Strided slices #158
Merged
Strided slices #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrianMichell, I fail to see any issues using isel with stride != 1. Can you explain in a bit more detail why you want to limit the functionality? |
|
This is removing that limitation that we imposed very early on. The concern was potentially mangling the written data and our access methods. This PR adds tests to ensure we don't inadvertently mangle with strided slices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to concerns about data integrity and API behavior,
isel(and Variable/VariableDataslice) were disallowed from having a stride other than 1.This PR resolves that issue and validates proper behavior.
#100 laid the groundwork for ensuring both
iselandselbehave as expected.