API: honour DB_HOST and DB_PORT #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API needs to wait for the database to be up before starting. We do not know how long it takes: just because the container is started doesn't mean that Postgres is ready. The workaround is to use a small script (start.sh) that waits until a connection to the database can be done before passing the execution to yarn. The Dockerfile contains hardcoded values for the database's hostname and ports, but there is no guarantee that these values are always the same. This is especially true when trying to deploy CTFNote with a previously-existing database. This commit removes the hardcoded values and replaces them with DB_HOST/DB_PORT.
|
This is already included in #237 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API needs to wait for the database to be up before starting.
We do not know how long it takes: just because the container is started doesn't mean that Postgres is ready. The workaround is to use a small script (start.sh) that waits until a connection to the database can be done before passing the execution to yarn.
The Dockerfile contains hardcoded values for the database's hostname and ports, but there is no guarantee that these values are always the same. This is especially true when trying to deploy CTFNote with a previously-existing database.
This commit removes the hardcoded values and replaces them with DB_HOST/DB_PORT.
Closes #234
Related to #200