[#12048] Migrate tests for DeleteAccountActionTest #13200
Conversation
|
Hi @mingyang143, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
mingyang143
changed the title
| Course stubCourse = new Course("course-id", "name", Const.DEFAULT_TIME_ZONE, "institute"); | ||
| Account stubAccount = new Account(googleId, "name", "[email protected]"); | ||
| Instructor instructor = new Instructor(stubCourse, "name", "[email protected]", | ||
| false, "", null, new InstructorPrivileges()); | ||
| instructor.setAccount(stubAccount); | ||
| String[] params = { | ||
| Const.ParamsNames.INSTRUCTOR_ID, instructor.getGoogleId(), | ||
| }; | ||
| DeleteAccountAction action = getAction(params); | ||
| MessageOutput actionOutput = (MessageOutput) getJsonResult(action).getOutput(); | ||
| assertEquals("Account is successfully deleted.", actionOutput.getMessage()); | ||
| assertNull(mockLogic.getInstructorByGoogleId(stubCourse.getId(), instructor.getGoogleId())); |
There was a problem hiding this comment.
I think that because the actual implementation of the action is so simple(we dont need the logic layer to return us any value etc) and we only need to test for SQL related code we can ignore the datastore method call.
Verifying that sqlLogic.deleteAccountCascade(googleId); is called once with the correct argument and the json output is correct should be enough.
One idea is to verify(mockLogic, times(1)).deleteAccountCascade(googleId) provided by Mockito this helps to ensure that the method is called and the INSTRUCTOR_ID from the request params is passed properly as an argument to the method.
There was a problem hiding this comment.
I just realized that since the treatment for both existing and non existing account is the same maybe we can just test this 2 cases:
- Null request params
- Non-Null request params
There was a problem hiding this comment.
I'm working on this now and will update soon.
mingyang143
force-pushed
the
branch-migrate-tests
branch
from
4fb253c to
8358271
Compare
Hi I have rebased this branch already. |
Part of #12048
Outline of Solution
Change DeleteAccountActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.