[FEAT] 메인 세팅 모달 퍼블리싱 #334
Merged
[FEAT] 메인 세팅 모달 퍼블리싱 #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrryu09
reviewed
Jan 9, 2025
| <PopUp type="title" /> | ||
| </MainSettingModalHeadLayout> | ||
| <MainSettingModalBodyLayout> | ||
| <DeadlineBox date={new Date()} endTime="06:00pm" label="마감 기간" /> |
There was a problem hiding this comment.
리턴문 위에서 변수 지정해 Date 담아두고 사용하면 렌더링할 때마다 데이트 오브젝트가 새로 생기지 않게 할 수 있을 것 같아요!!
There was a problem hiding this comment.
해당 date를 전달한 곳은 임시로 데이터를 넘겨주는 부분이라서 기능 붙이면서 수정하도록 하겠습니다!!
| startTime?: string; | ||
| endTime: string; | ||
| date: Date; | ||
| setDate: (newDate: Date) => void; |
There was a problem hiding this comment.
사소한 부분이지만 상탸를 직접적으로 변경하는 함수랑 헷갈릴 수도 있어 핸들~ 정도로 네이밍 바꿔주면 혼란을 줄일 수 있을 것 같아용
There was a problem hiding this comment.
앗 그러네요!! 해당 사항 수정하였습니다
| </TextBox> | ||
| </DateBtnLayout> | ||
| {isOpen && ( | ||
| <DropdownStyle tabIndex={-1}> |
wrryu09
approved these changes
Jan 9, 2025
|
설명 쪽 텍스트 길어질 경우도 확인해주시면 감사하겠습니당! |
Kjiw0n
requested changes
Jan 9, 2025
Comment on lines
+19
to
+27
| const placeholder = type === TYPE.TITLE ? '제목을 입력하세요' : '설명을 추가하세요'; | ||
|
|
||
| return ( | ||
| <PopUpContainer> | ||
| {type === TYPE.DESC && state === INPUT_STATE.DEFAULT && <Icon name="IcnDescription" size="tiny" />} | ||
| <StyledInput | ||
| type={type} | ||
| state={state} | ||
| placeholder="제목을 입력하세요" | ||
| placeholder={placeholder} |
Comment on lines
+31
to
+35
| <DeadlineBox date={new Date()} endTime="06:00pm" label="마감 기간" /> | ||
| <PopUpTitleBox> | ||
| <PopUp type="description" /> | ||
| </PopUpTitleBox> | ||
| <DeadlineBox date={new Date()} startTime="11:00am" endTime="06:00pm" label="진행 기간" /> |
There was a problem hiding this comment.
Suggested change
| <DeadlineBox date={new Date()} endTime="06:00pm" label="마감 기간" /> | |
| <PopUpTitleBox> | |
| <PopUp type="description" /> | |
| </PopUpTitleBox> | |
| <DeadlineBox date={new Date()} startTime="11:00am" endTime="06:00pm" label="진행 기간" /> | |
| <DeadlineBox date={new Date()} endTime="06:00 pm" label="마감 기간" /> | |
| <PopUpTitleBox> | |
| <PopUp type="description" /> | |
| </PopUpTitleBox> | |
| <DeadlineBox date={new Date()} startTime="11:00 am" endTime="06:00 pm" label="진행 기간" /> |
시간 수정할 때 정렬이 살짝 이상해서 봤더니 사이에 띄어쓰기가 업서요 수정해주세요!!
There was a problem hiding this comment.
여기 나중에 데이터 임시로 넣어둔 부분이라서 나중에 데이터 넣으면서 수정하도록 하겠습니다!
There was a problem hiding this comment.
위에 버튼 정렬에서 제가 보기에는 정렬이 맞게 보이는데 이상하네용 ,,ㅜ
|
테두리쪽 배경색은 기존 버튼 컴포넌트 자체에서 수정해야하는 부분 같아서 추후에 버튼 컴포넌트를 보는게 좋을 것 같습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 🧑💻
알게된 점 🚀
리뷰 요구사항 💬
관련 이슈
close #325
스크린샷 (선택)