[FEAT] 캘린더 v2 변경 #328
Open
[FEAT] 캘린더 v2 변경 #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kjiw0n
force-pushed
the
feat/#322/calendar-v2
branch
from
3900c2f to
3c0f862
Compare
Kjiw0n
force-pushed
the
feat/#322/calendar-v2
branch
from
fccdb2f to
345bc24
Compare
이쪽 정렬 한번만 확인해주세요!!
|
|
|
월간간뷰에서 스크롤이 안생기도록 조정할 수도 잇을까요?
|
wrryu09
approved these changes
Jan 3, 2025
Kjiw0n
force-pushed
the
feat/#322/calendar-v2
branch
3 times, most recently
from
d92e1f6 to
f9d9cb1
Compare
반영 완료했습니다! 꼼꼼하게 봐주셔서 감사합니다~~ |
jeeminyi
approved these changes
Jan 6, 2025
src/components/common/Icon.tsx
Outdated
There was a problem hiding this comment.
제 pc 상에서만 깨지는 거일 가능성이 높은데요..(pr에는 잘 보여서)
요거 정렬 혹시 왜 이럴까유,, 👀
There was a problem hiding this comment.
오잉 이 부분은 SubDate 컴포넌트 사용한건데, 혹시 이전 pr 확인하실때에도 이런 문제 있으셨을까요????
스토리북 확인해도 중앙에 맞게 떠서.. 글씨체 먹었는 지 확인 부탁드립니다
| .fc-toolbar-chunk .fc-button:active { | ||
| background: none; | ||
| } | ||
|
|
There was a problem hiding this comment.
으앙 여기 제가한건데 라디어스가 이상하네욤,, 돌아가면 고치겠슴다
There was a problem hiding this comment.
요거 FullCalendar에서 제공해주는 버튼을 다른 컴포넌트로 바꿔서 연결하는 게 기존버튼 스타일링보다 코드가 복잡해져서, 기존 버튼 스타일링하는 방식으로 했습니다 -> 제가했다는 소리...
FullCalnedar 자체 스타일링이 radius에 먹혀있어서 지우고 스타일링 조정했습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 🧑💻
알게된 점 🚀
리뷰 요구사항 💬
관련 이슈
close #322
스크린샷 (선택)
size = 'small'
size = 'big'
