fine tuning

TDAmeritrade · Feb 26, 2020 · 485bb23 · 485bb23
1 parent 845af3e
commit 485bb23
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/aws-eventdriven-osaudit/terraform/enable-ec2-syslog.tf b/aws-eventdriven-osaudit/terraform/enable-ec2-syslog.tf
@@ -11,6 +11,7 @@ data "aws_caller_identity" "current" {}
 data "aws_region" "current" {}
 
 resource "aws_iam_role" "lambda_role" {
+  name = "syslog-lambda-${var.aws_region}"
   assume_role_policy = <<EOF
 {
   "Version": "2012-10-17",
@@ -28,7 +29,7 @@ EOF
 }
 
 resource "aws_iam_role_policy" "CreateEC2Syslog" {
-  name = "CreateEC2Syslog"
+  name = "EnableEC2Syslog"
   role = "${aws_iam_role.lambda_role.id}"
   policy = <<EOF
 {
@@ -78,6 +79,7 @@ EOF
 }
 
 resource "aws_iam_role" "invocation_role" {
+  name = "syslog-invoke-${var.aws_region}"
   assume_role_policy = <<EOF
 {
   "Version": "2012-10-17",
@@ -114,7 +116,7 @@ EOF
 }
 
 resource "aws_iam_role" "ec2syslog_role" {
-  name = "Syslog"
+  name = "Syslog-${var.aws_region}"
   assume_role_policy = <<EOF
 {
   "Version": "2012-10-17",
@@ -132,7 +134,7 @@ EOF
 }
 
 resource "aws_iam_instance_profile" "ec2syslog_profile" {
-  name = "ec2syslog"
+  name = "syslog"
   role = "${aws_iam_role.ec2syslog_role.name}"
 }
 

diff --git a/aws-eventdriven-vpcflowlogs/enable-flow-logs.tf b/aws-eventdriven-vpcflowlogs/enable-flow-logs.tf
@@ -11,6 +11,7 @@ data "aws_caller_identity" "current" {}
 data "aws_region" "current" {}
 
 resource "aws_iam_role" "lambda_role" {
+  name = "enable-flow-logs-lambda-${var.aws_region}"
   assume_role_policy = <<EOF
 {
   "Version": "2012-10-17",
@@ -28,6 +29,7 @@ EOF
 }
 
 resource "aws_iam_role" "invocation_role" {
+  name = "enable-flow-logs-invoke-${var.aws_region}"
   assume_role_policy = <<EOF
 {
   "Version": "2012-10-17",
@@ -45,6 +47,7 @@ EOF
 }
 
 resource "aws_iam_role" "flowlogs_role" {
+  name = "enable-flow-logs-role-${var.aws_region}"
   assume_role_policy = <<EOF
 {
   "Version": "2012-10-17",

diff --git a/azure-automation-nsgdiagsettings/enable-nsg-diag-settings.tf b/azure-automation-nsgdiagsettings/enable-nsg-diag-settings.tf
@@ -36,7 +36,7 @@ resource "azurerm_automation_runbook" "automation_runbook_diag" {
   automation_account_name = "${data.azurerm_automation_account.automation_account.name}"
   log_verbose             = "true"
   log_progress            = "true"
-  description             = "This is an example runbook"
+  description             = "This runbook automates the enablement of diagnostic settings per Azure resource"
   runbook_type            = "PowerShell"
 
   publish_content_link {
@@ -53,7 +53,7 @@ resource "azurerm_automation_runbook" "automation_runbook_nsg" {
   automation_account_name = "${data.azurerm_automation_account.automation_account.name}"
   log_verbose             = "true"
   log_progress            = "true"
-  description             = "This is an example runbook"
+  description             = "This runbook automates the enablement of NSG flow logs per NSG and storage account region"
   runbook_type            = "PowerShell"
 
   publish_content_link {