Add did id to root record name #329
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
mistermoe,
nitro-neal,
tomdaffurn,
phoebe-lew,
kirahsapong,
jiyoonie9 and
frankhinek
as code owners
diehuxx
force-pushed
the
root-record-name
branch
from
d9790b7
to
fdbe974
Compare
jiyoonie9
reviewed
Jul 1, 2024
| @@ -459,7 +459,7 @@ public sealed class DidDhtApi(configuration: DidDhtConfiguration) { | |||
|
|
|||
| message.addRecord( | |||
| TXTRecord( | |||
| Name("_did."), DClass.IN, ttl, rootRecordText.joinToString(PROPERTY_SEPARATOR) | |||
| Name("_did.${didDocument.id.split(":")[2]}"), DClass.IN, ttl, rootRecordText.joinToString(PROPERTY_SEPARATOR) | |||
There was a problem hiding this comment.
could you write a test for this change?
jiyoonie9
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Bugfix in did:dht implementation
Description
The did dht spec says that the root record should have name like
_did.<id>where id is the last part ofdid:dht:123(Source).How Has This Been Tested?
Describe the tests that you ran to verify your changes. Provide instructions for verification.
Checklist
Before submitting this PR, please make sure:
References
Please list relevant documentation (e.g. tech specs, articles, follow up or related work) relevant to this change, and note if the documentation has been updated.