Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VS Code workspace #42

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Add VS Code workspace #42

merged 2 commits into from
Apr 29, 2024

Conversation

KendallWeihe
Copy link
Contributor

This'll grow as we add more crates, so this get's us started

Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not going to block but I don't love incorporating IDE specific files into shared workspaces.

@KendallWeihe
Copy link
Contributor Author

not going to block but I don't love incorporating IDE specific files into shared workspaces.

Ya know, I agree with this sentiment. We started doing this primarily for Hermit + Golang + FTL features but if we're really planning on these rust repos to be the core implementations for everything then I think that's right to not include IDE-specific matters. Can others weigh in on this matter?

Copy link
Contributor

@nitro-neal nitro-neal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KendallWeihe
Copy link
Contributor Author

Moving forward with this PR, stubbed in a issue on the backlog to discuss IDE-specific code assets #46

@KendallWeihe KendallWeihe merged commit 0db27e4 into main Apr 29, 2024
@KendallWeihe KendallWeihe deleted the kendall/vscode-workspace branch April 29, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants