Skip to content

Commit

Permalink
Merge pull request #64 from TAnas0/issue-63/remove-eslint-use-prettier
Browse files Browse the repository at this point in the history
Remove ESLint and use Prettier
  • Loading branch information
TAnas0 authored Sep 11, 2024
2 parents f08dfad + 4aeffb2 commit 7e727e7
Show file tree
Hide file tree
Showing 16 changed files with 196 additions and 857 deletions.
4 changes: 0 additions & 4 deletions .eslintignore

This file was deleted.

44 changes: 0 additions & 44 deletions .eslintrc.js

This file was deleted.

32 changes: 32 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: CI Pipeline

# Trigger the workflow on push and pull request events to the main branch
on:
push:
branches:
- main
pull_request:
branches:
- main

jobs:
build:
runs-on: ubuntu-latest # You can also use other runners like windows-latest or macos-latest

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: "22"

- name: Install dependencies
run: npm install

- name: Run linter
run: npm run lint:check

- name: Build the project
run: npm run build
1 change: 1 addition & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
*.json
7 changes: 7 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"semi": false,
"singleQuote": false,
"trailingComma": "es5",
"printWidth": 100,
"tabWidth": 2
}
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,11 @@ Please use the alias `npm run commit` for Commitizen friendly commits.
## Todos and roadmap

[NodeJS best practices checklist](https://github.com/i0natan/nodebestpractices):

- 1.5 Use environment aware, secure and hierarchical config

Using the [node-config] package with Webpack. See [](https://github.com/lorenwest/node-config/wiki/Webpack-Usage)

- Clean datasources
- Documentation and references
- GrahQL CLI scaffolding support
- GrahQL CLI scaffolding support
8 changes: 4 additions & 4 deletions docker-compose.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ services:
POSTGRES_PASSWORD: password
POSTGRES_DB: prisma
networks:
- 'prisma'
- "prisma"

prisma:
container_name: "prisma"
image: prismagraphql/prisma:1.22
restart: always
ports:
- 7766:7766
- 7766:7766
environment:
PRISMA_CONFIG: |
port: 7766
Expand All @@ -31,7 +31,7 @@ services:
# - api
- db
networks:
- 'prisma'
- "prisma"

# The API is better launched using `npm run dev` for hot reloading
# api:
Expand All @@ -46,4 +46,4 @@ services:

networks:
prisma:
driver: "bridge"
driver: "bridge"
Loading

0 comments on commit 7e727e7

Please sign in to comment.