chore: update AviRecord to comply with updated x265 API #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
carlocab
reviewed
Oct 30, 2024
| @@ -460,7 +460,8 @@ static int encode_frame( unsigned char *inBuf, int width, int height ) | |||
| pic->stride[1] = width/2; | |||
| pic->stride[2] = width/2; | |||
|
|
|||
| ret = x265_encoder_encode( hdl, &nal, &i_nal, pic, &pic_out ); | |||
| x265_picture *pic_out = nullptr; | |||
There was a problem hiding this comment.
Not sure this looks right. Aren't you shadowing
fceux/src/drivers/Qt/AviRecord.cpp
Line 392 in f980ec2
?
carlocab
reviewed
Oct 30, 2024
Comment on lines
+463
to
+464
| x265_picture *pic_out = nullptr; | ||
| ret = x265_encoder_encode(hdl, &nal, &i_nal, pic, &pic_out); |
There was a problem hiding this comment.
I suspect this maybe should be something like
Suggested change
| x265_picture *pic_out = nullptr; | |
| ret = x265_encoder_encode(hdl, &nal, &i_nal, pic, &pic_out); | |
| x265_picture *pic_out_ptr = &pic_out; | |
| ret = x265_encoder_encode(hdl, &nal, &i_nal, pic, &pic_out_ptr); |
Hard to say though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #760
relates to Homebrew/homebrew-core#189134