Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main window auto-size fixes #4029

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

kalimag
Copy link
Contributor

@kalimag kalimag commented Sep 13, 2024

  • Ensure that the top left corner of the window remains on screen if the entire window cannot fit at 1x scale
    • Fix title bar/menu moving off-screen with unusually large framebuffer sizes
    • The bottom/right edge may move off-screen instead, but that seems like the lesser evil
  • When MainWindow.FrameBufferResized is called while the window is minimized or maximized, defer the resize until the window is restored to normal again
    • Fix window being disproportioned or moving erratically because the resize logic was working off of the minimized/maximized window sizes
  • Remember window maximized state after restart

Resolves #2850

Check if completed:

Copy link
Member

@YoshiRulz YoshiRulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to clarify, does this fix the linked issue for fullscreen or just maximised? Our fullscreen isn't real fullscreen anyway so I expect it's both.

@kalimag
Copy link
Contributor Author

kalimag commented Sep 13, 2024

Yeah it works for "fullscreen" as well.

@YoshiRulz YoshiRulz merged commit ed13e0e into TASEmulators:master Sep 13, 2024
4 checks passed
@kalimag kalimag deleted the pr/framebufferresized-fixes branch September 13, 2024 13:46
CasualPokePlayer added a commit that referenced this pull request Sep 19, 2024
…/height

while this did "work", and mimicked other emulators handling internal upscaling, it was a hack, and ends up causing issue with lua padding. it is also more unneeded now that #4029 (makes the UX of a sudden "large window" more managable) and #4011 (allowing for mimicking the frozen smaller window state) are merged

resolves #4039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window Size & position incorrectly adjusted when exiting Fullscreen
2 participants