Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Data.SQLite -> Microsoft.Data.Sqlite #3719

Merged

Conversation

CasualPokePlayer
Copy link
Member

@CasualPokePlayer CasualPokePlayer commented Aug 4, 2023

https://learn.microsoft.com/en-us/dotnet/standard/data/sqlite/compare

Seems to be a sort of successor / "modern variant" of System.Data.SQLite? netstandard2.0 so great for us I suppose. I assume it works for Linux? (System.Data.SQLite didn't lol). A quick testing of commands seems to say it works on Windows at least.

Also would eliminate another .NET Framework dep (see #2261).

Check if completed:

@YoshiRulz

This comment was marked as outdated.

@YoshiRulz
Copy link
Member

Works under Mono on NixOS, without host SQLite lib even.

@CasualPokePlayer
Copy link
Member Author

CasualPokePlayer commented Aug 4, 2023

Microsoft.Data.Sqlite doesn't attempt to use the host SQLite lib, rather it tries to bundle a build which has a custom naming scheme (e_ prefix). With the latest commit I prevent it from trying to do that directly (as it ends up creating some runtimes folder which doesn't work out) and just put its builds (i.e. relevant e_sqlite3.dll and libe_sqlite3.so builds) in the Assets folder.

FWIW the System.Data.SQLite we had was a mixed assembly with effectively a windows x64 copy of the sqlite dll bundled into it, which would have not work on Linux in any case.

@CasualPokePlayer CasualPokePlayer merged commit bb96825 into TASEmulators:master Aug 6, 2023
@CasualPokePlayer CasualPokePlayer deleted the microsoftsqlite branch August 6, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants