Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing UpdateDialog call in LuaConsole #3492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing UpdateDialog call in LuaConsole #3492

wants to merge 1 commit into from

Conversation

kalimag
Copy link
Contributor

@kalimag kalimag commented Dec 13, 2022

Call UpdateDialog after the script is refreshed, in case the script was disabled by a new syntax error etc.

@kalimag
Update Lua dialog after reloading script
674c407 
In case script state changes due to error
@YoshiRulz
Copy link
Member

For anyone else who was confused by this: OnLuaFileChanged can only be called when "Reload When Script File Changes" is enabled (defaults to disabled).

YoshiRulz
YoshiRulz reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@YoshiRulz YoshiRulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is in the wrong spot. RefreshLuaScript should check item.State after the first call to ToggleLuaScript (and before the first call for that matter), then this can go just before RefreshLuaScript returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoshiRulz YoshiRulz YoshiRulz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalimag @YoshiRulz