-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .git-blame-ignore-revs #3349
base: master
Are you sure you want to change the base?
Add .git-blame-ignore-revs #3349
Conversation
This could be used for ignoring giant whitespace changes in git blames. With this we could commit to doing giant tab/space + newline normalization in .cs files without blame noise.
1064871
to
41cabd6
Compare
GitHub doesn't respect this in file history (example). I still like this idea though. |
Well, this feature seems to be intended for |
...or would, if the commit changed any lines in that file. I've actually changed my mind and am now skeptical of this feature. How exactly does it "see beyond" the filtered commit(s)? Does it only try if the filter commit(s) are whitespace-only? In any case, I'd like to see it in action. edit: Having reviewed the docs, it seems this has no downsides if we ensure it's only used for trivial whitespace changes. some more commits to consider: |
https://github.com/Morilli/BizHawk/blame/master/.editorconfig ... I think that's working? |
Care to revisit this? As per my edits above, I think we should use this feature only for whitespace changes (and file renames). |
This could be used for ignoring giant whitespace changes in git blames.
With this we could commit to doing giant tab/space + newline normalization in .cs files without blame noise. edit: and trailing newlines --yoshi
The commit used here is used more for POC, although still nice for getting rid of the blame noise from it.