-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: load static not staticfiles templatetag #628
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously installed branch was merged to main.
- fix(fonts): fp-1891 add regular italic, also add black (#71) - feat(objects): warning about still-disabled o-site - feat(components): icon updates from Core-Portal - docs(trumps): comment about lifespan of u-empty - chore(elements): body margin 0 - feat(dist): commit dist for clients relying on it (#70) - chore: import dependencies in each pattern
In Core-Styles, icon CSS moved: trumps/icon → components cortal.icon.
J.R. and I agree a real CDN makes sense for Core-Styles, long-term. J.R. doesn't know about this temp solution yet. He'll have better idea.
No need to re-build Core-Styles since we have it's `dist/`. Related PR: TACC/Core-Styles#70
- Add core styles version setting. - Load core-styles from pseudo-CDN. - Use new CSS layer tech to load stylesheets.
…' into dev/tup-cms
feat: bootstrap modal styles (#147)
- changed news articles to be wider - added styles for figure and blockquote and captions
The default should be 2, because anyone loading CMS beyond v3.9.2 has package.json pointed to a Core-Styles v2. How to make TACC_CORE_STYLES_VERSION = 0 __really_ work (given one `package.json`)? I don't know. That is for #605 to solve.
…Core-CMS into task/get-core-styles-beyond-0.11.0
core-styles.base.css defaults to blue accent color
Do not mix usage of these plugins: - postcss-nested - postcss-custom-seletctor - postcss-extend It is unclear which is to blame, but postcss-extend is the oldest and is for a dead feature proposal.
* fix(core-styles): x-figure, x-blockquote mistakes * fix(css): remove cruft fixes for p.caption * fix(css): p.caption not to inherit from .x-figure This was confusing. And undoing this gives p.cation larger margin-bottom (from p). * fix(css): p.caption no inherit .x-figure FOR REAL * chore(core-styles): install v2.6.2
* fix: add+use core-styles.wysiwyg.css, no copy code Create a `core-styles.wysiwyg.css` to load that code from installed Core-Styles (rather than rely on copied code). * fix(...ckeditor): only use @import in contents.css
CSS layers will take care of what the `:where()` was supposed to do.
As is done in #626.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Load
static
notstaticfiles
template tag, so #626 does not break.Related
Changes
Testing
'staticfiles' is not a registered tag library. Must be one of:
.UI