Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: load static not staticfiles templatetag #628

Closed
wants to merge 230 commits into from

Conversation

wesleyboar
Copy link
Member

Overview

Load static not staticfiles template tag, so #626 does not break.

Related

Changes

  • rename templatetag load in many templates

Testing

  1. Build TUP CMS using feat(tup-cms): update django to v3.2 tup-ui#225.
  2. Load CMS in browser.
  3. Verify no TemplateSyntaxError 'staticfiles' is not a registered tag library. Must be one of:.

UI

Before After
templatesyntaxerror

wesleyboar and others added 30 commits November 15, 2022 21:40
The previously installed branch was merged to main.
- fix(fonts): fp-1891 add regular italic, also add black (#71)
- feat(objects): warning about still-disabled o-site
- feat(components): icon updates from Core-Portal
- docs(trumps): comment about lifespan of u-empty
- chore(elements): body margin 0
- feat(dist): commit dist for clients relying on it (#70)
- chore: import dependencies in each pattern
In Core-Styles, icon CSS moved: trumps/icon → components cortal.icon.
J.R. and I agree a real CDN makes sense for Core-Styles, long-term.

J.R. doesn't know about this temp solution yet. He'll have better idea.
No need to re-build Core-Styles since we have it's `dist/`.

Related PR: TACC/Core-Styles#70
- Add core styles version setting.
- Load core-styles from pseudo-CDN.
- Use new CSS layer tech to load stylesheets.
wesleyboar and others added 28 commits March 24, 2023 10:20
feat: bootstrap modal styles (#147)
- changed news articles to be wider
- added styles for figure and blockquote and captions
The default should be 2, because anyone loading CMS beyond v3.9.2 has package.json pointed to a Core-Styles v2.

How to make TACC_CORE_STYLES_VERSION = 0 __really_ work (given one `package.json`)? I don't know. That is for #605 to solve.
…Core-CMS into task/get-core-styles-beyond-0.11.0
core-styles.base.css defaults to blue accent color
Do not mix usage of these plugins:
- postcss-nested
- postcss-custom-seletctor
- postcss-extend

It is unclear which is to blame, but postcss-extend is the oldest and is for a dead feature proposal.
* fix(core-styles): x-figure, x-blockquote mistakes

* fix(css): remove cruft fixes for p.caption

* fix(css): p.caption not to inherit from .x-figure

This was confusing. And undoing this gives p.cation larger margin-bottom (from p).

* fix(css): p.caption no inherit .x-figure FOR REAL

* chore(core-styles): install v2.6.2
* fix: add+use core-styles.wysiwyg.css, no copy code

Create a `core-styles.wysiwyg.css` to load that code from installed Core-Styles (rather than rely on copied code).

* fix(...ckeditor): only use @import in contents.css
CSS layers will take care of what the `:where()` was supposed to do.
@wesleyboar wesleyboar closed this May 3, 2023
@wesleyboar wesleyboar deleted the dev/tup-cms--statif-not-staticfiles branch May 3, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant