feat(dev/tup-cms): django3, blog/news styles + related patterns #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix(icon): hide text inside icon (TACC/Core-Styles#86) - fix(package): move npm-watch to devDeps (TACC/Core-Styles@8b2ee16) - feat(cortal.icons): collapse alias (TACC/Core-Styles#85)
- newest cms button styles - load cms button in new cms stylesheet - load core button in old cms stylesheet - avoid duplicate load of stylesheets
- `core-styles.cms.css` will load core-styles font sizes
- core-styles@v0-only cuz `assets_core_cms.html` conditional load
- `site.css` will load core-styles font sizes
- core-styles@v0-only cuz `assets_site.html` conditional load
It was "16px", then moved up to "18px" with font size value changes, but design wants it at "12px".
Adapt CMS to use: - TACC/Core-Styles#92 - TACC/Core-Styles#93
To start fresh with global Snippet styles, then move em to Core-Styles.
…Core-CMS into task/get-core-styles-beyond-0.11.0
Load core-styles.demo.css before base, just like TACC/Core-Styles.
Let cms styles be applied per pattern, like core-styles does. - So, core-styles and core-cms demo do not differ. - Thus, portal and cms can reliably reference demo. A bonus is that core-styles cms and portal stylesheets are pressured be accurate.
Use new feature from Core-Styles.
Breaking Change: CMS Font sizes and names moved. Check its commit.
By building default context atop core-styles, we define less paths.
This is atop the card & section patterns I've been installing/updating.
- supports link plugins and image link attributes - fixes link title (from image alt)
These projects have been migrated to: https://github.com/TACC/Core-CMS-Custom/ Or, in the case of tup_cms, are in their own repo: https://github.com/TACC/tup-ui
|
The test of #674 on ECEP (which has News and v3.12 bugs since fixed) was the only functional blocker.1 Footnotes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A dev branch for all new TUP CMS work.
This branch is used to build images for https://github.com/TACC/tup-ui/tree/main/apps/tup-cms. This lets me deploy everything so I can test "New Stuff A" without removing "New Stuff B". I will continuously deploy this branch for CMS changes. I keep this branch up to date merely by
git merge other/branch-nameas updates from other branches come.Related / Changes / Testing / UI