task/WG-418 - File Listing Component Enhancement and Fixes #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayanaijaz
requested review from
rstijerina,
nathanfranklin and
sophia-massie
rstijerina
approved these changes
Feb 27, 2025
Comment on lines
+88
to
+91
| listingState.path || | ||
| (selectedSystem?.id === myDataSystem?.id ? user?.username : ''), | ||
| offset: listingState.offset.toString(), | ||
| limit: DEFAULT_FILE_LIMIT.toString(), |
There was a problem hiding this comment.
Few suggestions for future improvement:
- offset and limit should be type int, and adjust in the hook query params
- react query has a nice infinite query hook. Used in tandem with
InterSectionObserver, orreact-intersection-observer, this would simplify this code a bit with the use of a ref for a node at the bottom of the listing, and a callback to the react-query built-infetchNextPage()method. If gone that route, you'd be able to get rid of most of theuseStates in this component
| const [selectedSystem, setSelectedSystem] = React.useState<TTapisSystem>( | ||
| myDataSystem as TTapisSystem | ||
| ); | ||
| const [hasError, setHasError] = React.useState(false); | ||
| const [loadingMoreFiles, setLoadingMoreFiles] = React.useState(false); |
There was a problem hiding this comment.
Could we use the isLoading state from the useFiles hook instead?
|
|
||
| if (!dynamicListContainer) return; | ||
|
|
||
| const handleScroll = debounce(() => { |
There was a problem hiding this comment.
nitpick and you don't need to take my advice, but personally I like to avoid lodash. Is there a way to handle the scroll event in this way without the debounce frequency?
Comment on lines
+311
to
+313
| {loadingMoreFiles && ( | ||
| <p style={{ textAlign: 'center' }}>Loading...</p> | ||
| )} |
There was a problem hiding this comment.
Could use a bit more vertical padding here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Adds infinite scrolling for file listing. Fixes bugs related to invalid file selection and empty message.
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes:
TODO: