task/WG-430: implement taggit gallery navigation #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clicking on tab test was broken as all components rendered so it needed to be improved to check if that components was inside active tab
sophia-massie
approved these changes
Feb 25, 2025
rstijerina
approved these changes
Feb 25, 2025
nathanfranklin
deleted the
task/WG-430-implement-taggit-gallery-navigation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This implements navigating to taggit. Note taggit doesn't have project-specific routes so we have to write to local storage.
Also tweaked the
switches between tabs correctlytest as all components in tabs are rendered so reworked to check if active component was in active tab.PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
It’s slightly difficult to test in local development since we don’t currently run Taggit alongside Hazmapper.
navigate(config.taggitUrl);to see that it would navigate tolocalhost:/taggit-local