bug/wg-447-import-loading-bug #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophia-massie
requested review from
nathanfranklin,
rstijerina and
shayanaijaz
rstijerina
reviewed
Feb 24, 2025
Comment on lines
37
to
39
| useEffect(() => { | ||
| setIsSuccess(false); | ||
| }, [selectedFeature.id]); |
There was a problem hiding this comment.
would this not work with the isSuccess value from the mutation instead?
There was a problem hiding this comment.
Not as it is no. The isSuccess key is the selected project feature list not the specific feature. Adding the feature id as an additional key won't update the list in the LoadedProject component. The loaded map project is looking for the feature id to change and since the import doesn't change an id, we are invalidating the key list features on import. The trickle down of selectedfeature state from loadedmapproject could possibly use some refactoring based on these conflicts
rstijerina
reviewed
Feb 25, 2025
rstijerina
approved these changes
Feb 25, 2025
Co-authored-by: Sal Tijerina <[email protected]>
rstijerina
reviewed
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes: