Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/WG-436: use system path during project creation #330

Merged

Conversation

nathanfranklin
Copy link
Collaborator

Overview:

Fix system path during project creation.

This PR also makes some small changes to the display of the projects' system/path in the manage panel.

PR Status:

  • Ready

Related Jira tickets:

Testing Steps:

  1. Create a new map in subfolder in My Data or in a project
  2. Confirm that this works as expected by checking POST or the links or the location of the .hazmapper file. Also, check the display/links of related DS project are correct in the Manage Panel.

@@ -110,7 +110,7 @@ const SaveTabContent: React.FC<SaveTabProps> = ({ project }) => {
rel="noreferrer"
style={{ padding: 0 }}
>
{project.system_id}
My Data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we show My Data here for designsafe.storage.default, we should change the project.system_path above to be handled similarly to the saveLocationDisplay:

Copy link
Collaborator Author

@nathanfranklin nathanfranklin Feb 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. gonna merge current PR and draft up this change.

@rstijerina , put in https://tacc-main.atlassian.net/browse/WG-437

Copy link
Contributor

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, not a blocker

@nathanfranklin nathanfranklin merged commit 0211a93 into main Feb 18, 2025
5 checks passed
@nathanfranklin nathanfranklin deleted the fix/WG-436-use-system-path-during-project-creation2 branch February 18, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants