Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-425: Fix asset panel css #321

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

rstijerina
Copy link
Contributor

Overview:

Fixes css preventing asset panel from scrolling properly.

PR Status:

  • Ready.

Related Jira tickets:

Summary of Changes:

  • makes FeatureFileTree scrollable by setting max-height
  • replaces AssetPanel buttons with Ant buttons
  • fixes base panel height

Testing Steps:

  1. Go to http://localhost:4200/project/db8f8bc8-4a48-4fd4-9009-8a201d19f81a?panel=Assets with prod settings, or another project with lots of assets
  2. Shrink your window, and confirm you can see all buttons if you scroll

UI Photos:

Screenshot 2025-02-13 at 12 24 29 PM
Screenshot 2025-02-13 at 12 24 47 PM

Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sophia-massie
Copy link
Contributor

sophia-massie commented Feb 13, 2025

Looks good! Can merge and I can add this to the testing document.

When a map is loading all the file nodes, the export GeoJson button appears at the bottom of the listing and you have to scroll to see it. When the file tree finally loads, then the export button is sticky. Try importing 5000_points.geojson from the screen shot to a map to re-create. Could use possibly a loading spinner there until all assets load from the File Tree component.
Screenshot 2025-02-13 at 2 59 54 PM

On page load before loading large File Listing
Screenshot 2025-02-13 at 3 01 41 PM

While assets are loading/populating
Screenshot 2025-02-13 at 3 01 58 PM

When assets finish populating

Screenshot 2025-02-13 at 3 01 28 PM

@nathanfranklin
Copy link
Collaborator

nathanfranklin commented Feb 13, 2025

Looks good! One thing - When a map is loading all the file nodes, the export GeoJson button appears at the bottom of the listing and you have to scroll to see it. When the file tree finally loads, then the export button is sticky. Try importing 5000_points.geojson from the screen shot to a map to re-create. Could use possibly a loading spinner there until all assets load from the File Tree component.

Could we merge and do this as follow-up work?

(note, i am working on something that indirectly touches that: https://tacc-main.atlassian.net/browse/WG-432. not the loader/sinner but just something that would produce similar behavior when changing filters or getting updated features; so then it might be more easy to see the issue pointed out above)

@nathanfranklin
Copy link
Collaborator

nathanfranklin commented Feb 13, 2025

Looks good! One thing - When a map is loading all the file nodes, the export GeoJson button appears at the bottom of the listing and you have to scroll to see it. When the file tree finally loads, then the export button is sticky. Try importing 5000_points.geojson from the screen shot to a map to re-create. Could use possibly a loading spinner there until all assets load from the File Tree component.

@sophia-massie also related to the export and import button's stickyness. its only sticky if you have a selected feature, right? and then we have slightly different behavior in point cloud listings and tile layers listings. and all 3 of those areas vary from angular-version. 🤔 . not certain what is the behavior we want.

@rstijerina rstijerina merged commit 0b9281a into main Feb 13, 2025
5 checks passed
@rstijerina rstijerina deleted the task/WG-425--fix-asset-panel-css branch February 13, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants