-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task/wg 243 manage project #313
base: main
Are you sure you want to change the base?
Conversation
Map Tab complete. Other tabs WIP
updates hook, manages hook state on the main panel
- adjusts paginator to fit in panel - removes debug statement in members tab
- Removes reset so that notifications on map don't bounce on state reset
Need clarification of when members should appear. I created a map not related to a DS project and the useProjectUsers hook still brought back users. I tried filtering first to make sure that project.ds_project existed before getting the useProjectUsers data. Using this filter, however, caused all maps, even if they were related to a DS project, to return no users. |
Open to suggestions on factoring out the success state passed from the delete modal to the homepage after redirect. |
looks like useProjectUsers is missing the project-id in its key. so that bug in main is probably causing the issue https://github.com/TACC-Cloud/hazmapper/blob/main/react/src/hooks/projects/useProjectUsers.ts#L16 |
conditional excluding the manage panel sneak back in
…zmapper into task/WG-243-manage-project
map is not associated with DS project
- Adds option to user hook to only get if map is associated with DS project
Updated the hook. Should be working as expected now. Thanks for the help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! 💯 Just left some comments to consider.
react/src/components/ManageMapProjectPanel/MembersTabContent.tsx
Outdated
Show resolved
Hide resolved
react/src/components/ManageMapProjectPanel/PublicTabContent.tsx
Outdated
Show resolved
Hide resolved
react/src/components/ManageMapProjectPanel/PublicTabContent.tsx
Outdated
Show resolved
Hide resolved
react/src/components/ManageMapProjectPanel/MembersTabContent.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Nathan Franklin <[email protected]>
- Adds links to DesignSafe modeled after angular in the save tab of manage panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added links to DesignSafe in the Save tab like prod. Addressed requested changes. Ready for another review 👍
Overview:
Adds Manage Panel functionality to map
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
or
UI Photos:
Map Tab
Edit
Invalid Edit
Success
Delete returns to home with notification
Members Tab
If map is not associated with a DesignSafe project
Has many members
Public Tab
Is Private
Is Public
Save Tab
Notes:
The Taggit link does not work locally.