Task/WG-239 point cloud panel #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update Streetview to hide when in public view
|
LGTM. I've noticed this one issue when importing assets before - not a bug with this change. The asset listing doesn't pick up new assets as they're added to the project. After refresh, the red rock point cloud then appears. |
sophia-massie
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Add point cloud panel
This PR also ensures non-public nav items are not shown and routed away and that Streetview is hidden when in public-view. See this commitput in separate PR #310. Please review that first.PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
UI Photos:
Notes:
Consider combining IFileImportRequest and TapisFilePathPlaced IFileImportRequest/TapisFilePath together and added a noteLeaving add-point-cloud button to use same icon as Layers Panel.