Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/152 bug update get simpleadminauditlogps1 to parse search unifiedauditlog results #175

Conversation

jonnybottles
Copy link
Collaborator

Migration to Search-UnifiedAuditLog for Multiple Functions

This PR addresses the following tickets:

Key Changes

New Function

  • Added Get-SimpleUnifiedAuditLog to handle parsing of Search-UnifiedAuditLog results
  • This new function will eventually replace Get-SimpleAdminAuditLog once all dependent functions are migrated
  • Includes comprehensive parsing of all fields and nested arrays from audit log entries
  • Handles null object scenarios and provides consistent output formatting

Updated Functions

  • Modified Get-HawkUserAdminAudit to use Search-UnifiedAuditLog with pagination support
  • Renamed and updated Get-HawkTenantRbacChanges to Get-HawkTenantRbacChange for PSSA compliance
  • Both functions now use Get-AllUnifiedAuditLogEntry to ensure complete data retrieval
  • Standardized output formats and improved error handling

Notable Improvements

  • Implemented consistent schema ordering in CSV outputs as specified
  • Added better error handling and logging throughout
  • Improved documentation and comment-based help
  • Maintained backward compatibility while modernizing the codebase

Important Note

Get-SimpleAdminAuditLog remains unchanged for now to maintain compatibility with functions not yet migrated to Search-UnifiedAuditLog. It will be deprecated in a future update once all dependent functions are migrated.

…. User changes still has raw auditlog blob in it.
…nested arrary from the audit log entry. This will allow for @topcyber to determine what fields to keep and get rid of.
… per PSSA scan hit and change all references to Get-HawkTenantRBAChange.
… per PSSA scan hit and change all references to Get-HawkTenantRBAChange.
…o handle pagenation and retrieve all results.
…the direction of our Lord and Savior, the Cloud Messiah himself, and Ruling Cloud Architect, Paul Navarro.
Copy link
Owner

@T0pCyber T0pCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@T0pCyber
Copy link
Owner

Closing without merge. New PR Coming.

@T0pCyber T0pCyber closed this Dec 15, 2024
@T0pCyber T0pCyber deleted the bugfix/152-bug-update-get-simpleadminauditlogps1-to-parse-search-unifiedauditlog-results branch December 15, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants