Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing newest logs first. Removed newest entry button #21

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

amit0rana
Copy link

Newest logs should show on top. Having to click a button every time to see latest logs is not user friendly.

There are two changes in this:

  1. reversed the array of lines read from log file
  2. Removed the newest entry button.

@amit0rana
Copy link
Author

added extra info in the view.

@mpbzh
Copy link
Contributor

mpbzh commented Oct 11, 2015

I'd rather not make this default behavior, as oldest to newest is the order in which the log file is writing the lines and it appears more intuitive to me.

However as this is personal preference and I absolutely see the practical use of it, I suggest an implementation where oldest to newest is default behavior but can be reversed by setting a ReverseLineOrder (or similar) flag in the config file.

@amit0rana
Copy link
Author

makes sense. I will implement that.

@rdev5
Copy link

rdev5 commented Nov 27, 2015

I think I have to concur with @amit0rana. The older logs are, the less relevant they become to the log viewer and eventually get to the point where they finally get archived or deleted altogether. Therefore, the log viewer in this "domain" should default to ORDER BY timestamp DESC as that is its role, for viewing logs.

Perfect example of this as being an industry accepted "default behavior" would be your online bank account activity. It's ordered the same way because we're more interested in recent transactions and the majority of our time will be spent there, only scrolling to older history when we have to.

Another way to think about it is that logs in this domain ordered by "oldest first" are less intuitive in the sense that once you've already seen them, you typically don't need to keep seeing them. Administrators and even developers are better served by event viewers that show them what's happening now vs. what happened when they first installed the system.

Just my two cents. Sorry for the lengthy reply; the more I thought about this, the more I ended up typing and got carried away :P

@mpbzh
Copy link
Contributor

mpbzh commented Mar 2, 2016

The current master branch contains many changes, including the newest-to-oldest sorting behavior as default. I've been using it for some time and you are right, it's much more comfortable to work with. I'll keep it the default behavior, but still offer an option to switch back to the "native" sorting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants